My first Drupal module

[giza]

So, I wrote my first Drupal module over the weekend:

http://drupal.org/node/49053

The module is called "Sanity". When run, it checks your Drupal installation for any issues that might cause it to hog lots of CPU time. Hopefully others will find it useful.

Comments

[pyesetz]

Congratulations on your new free software contribution!  Yours is now one of 572 contributed modules at drupal.org.

I like this code report: "The else-clause at line 136 puts '}' and 'else' on the same line. To conform Drupal's coding conventions they should be on separate lines."  Drupal's convention is wrong—it looks better to say } else { as you have it.

Your program source says only "GNU Public License" without specifying a version number.  Your LICENSE file is GPL v2.  Are you copying Linus in his refusal to allow use of GPL v3 (when released) with your module?

[giza.livejournal.com]

> I like this code report: "The else-clause at line 136 puts '}' and 'else' on
> the same line. To conform Drupal's coding conventions they should be on
> separate lines." Drupal's convention is wrong—it looks better to say } else
> { as you have it.

Where do you see that?

[pyesetz]

From the Drupal page you linked, click on "View code report" (left-hand column, near bottom).

[giza.livejournal.com]

Heeeey, that's pretty hot! I'll be making some changes to that tonight!